Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39327 )
Change subject: cbfs: Move more stuff into cbfs_boot_lookup() ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/39327/3/src/lib/cbfs.c File src/lib/cbfs.c:
https://review.coreboot.org/c/coreboot/+/39327/3/src/lib/cbfs.c@37 PS3, Line 37: err == CB_CBFS_NOT_FOUND) { same line like before?
https://review.coreboot.org/c/coreboot/+/39327/3/src/lib/cbfs.c@62 PS3, Line 62: const struct region_device *bootdev = boot_device_ro(); Why is this boot_device_ro()? Below you are using rdev_relative_offset() with bootdev and the result of cbfs_boot_lookup() where cbfs_get_boot_device() may return something different. You'll need to match those by passing in &bootdev to cbfs_boot_lookup() it can properly fill out the pointer.
https://review.coreboot.org/c/coreboot/+/39327/3/src/security/tpm/tspi/crtm.... File src/security/tpm/tspi/crtm.h:
https://review.coreboot.org/c/coreboot/+/39327/3/src/security/tpm/tspi/crtm.... PS3, Line 48: struct region_device *rde const
https://review.coreboot.org/c/coreboot/+/39327/3/src/security/tpm/tspi/crtm.... File src/security/tpm/tspi/crtm.c:
https://review.coreboot.org/c/coreboot/+/39327/3/src/security/tpm/tspi/crtm.... PS3, Line 109: rdev variable naming conflict.