Attention is currently required from: Paul Menzel. chris wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48733 )
Change subject: soc/amd/picasso: Set UPDs for tuning eDP phy ......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/48733/comment/3dbbf409_5cf3dff4 PS2, Line 7: soc/amd/picasso: Add UPDs for support edp phy tuning adjust
Maybe: […]
Done
File src/soc/amd/picasso/chip.h:
https://review.coreboot.org/c/coreboot/+/48733/comment/1190ca28_28fcd8dd PS2, Line 60: /// dpphy_override
Please use consistent commenting style in this file, which seems C89.
Done
https://review.coreboot.org/c/coreboot/+/48733/comment/f78ed3d5_4ae174a5 PS2, Line 62:
Plesae use one space, or be consistent with the rest (though I do not see the benefit of using two s […]
Done
https://review.coreboot.org/c/coreboot/+/48733/comment/56380732_a892252d PS2, Line 238: uint8_t dp_phy_override; : uint16_t edp_phy_sel; : uint8_t edp_version; : uint16_t edp_table_size; : : struct { : uint8_t dp_vs_pemph_level; : uint8_t deemph_6db4; : uint8_t boostadj; : uint16_t margin_deemph; : } edp_tuningset;
Please use one space as in the rest of the file.
Done