[coreboot-gerrit] [M] Change in coreboot[master]: drivers/intel/fsp2_0: Read MRC version from FSP binary

[Ronak Kanabar (Code Review)]

Attention is currently required from: Andrey Petrov, Hannah Williams, Paul Menzel, Subrata Banik, Tarun Tuli.

Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75524?usp=email )

Change subject: drivers/intel/fsp2_0: Read MRC version from FSP binary
......................................................................

Patch Set 12:

(3 comments)

File src/drivers/intel/fsp2_0/Kconfig:

https://review.coreboot.org/c/coreboot/+/75524/comment/5caf00b2_5d33df98 :
PS3, Line 405: MRC_VERSION_FROM_BIN
> > @traun ADL/RPL changes will take some more time. I will share more details on bug.  […]

we can use FSP_HEADER_HAS_MRC_VERSION_INFO FSP_HEADER_HAS_MRC_VERSION_INFO_2.

let me do the change is accordingly.

File src/drivers/intel/fsp2_0/include/fsp/soc_binding.h:

https://review.coreboot.org/c/coreboot/+/75524/comment/4151b4b4_b981e3cb :
PS12, Line 30: MRC_VERSION_FROM_BIN
> FSP_HEADER_HAS_MRC_VERSION

Acknowledged

https://review.coreboot.org/c/coreboot/+/75524/comment/34825172_289ca8ff :
PS12, Line 32:  TODO: Remove BUILD_TIME_STAMP_SIZE Macro from coreboot once Macro
             :  * definition is in 'FspProducerDataHeader.h'.
> what is the timeline ? like next EDK2 uprev ?

FSP 3205+ headers have the fix. mostly next release.