Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43845 )
Change subject: soc/skylake: Enable SMBus depending on devicetree configuration
......................................................................
Patch Set 4: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/43845/4/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43845/4/src/mainboard/google/voltee...
PS4, Line 32: chip soc/intel/tigerlake
Hey, this is Volteer
https://review.coreboot.org/c/coreboot/+/43845/4/src/soc/intel/skylake/romst...
File src/soc/intel/skylake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/43845/4/src/soc/intel/skylake/romst...
PS4, Line 300: config
no
https://review.coreboot.org/c/coreboot/+/43845/4/src/soc/intel/skylake/romst...
PS4, Line 302: dev ? dev->enabled : 0
dev && dev->enabled
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43845
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0d9ec1888c82cc6d5ef86d0694269c885ba62c41
Gerrit-Change-Number: 43845
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 25 Jul 2020 09:23:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment