Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Arthur Heymans, Fred Reitberger, Karthik Ramasubramanian, Felix Held.
Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Matt DeVillier, Arthur Heymans, Fred Reitberger, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/68584
to look at the new patch set (#4).
Change subject: soc/amd: Define AMD_FWM_POSITION config item ......................................................................
soc/amd: Define AMD_FWM_POSITION config item
AMD_FWM_POSITION defines the location of the AMD Firmware Directory Table in the memory map. Currently an index is defined and the position is computed at build time using makefile arithmetic. Eventhough the formula to calculate the AMD_FWM_POSITION works now, we are not sure if it is correct. Hence define the AMD_FWM_POSITION config item and create a one-to-one mapping between AMD_FWM_POSITION_INDEX and AMD_FWM_POSITION. This mapping will ensure that the unexpected AMD_FWM_POSITION is not configured. This change also cleans up some copy-paste duplication.
BUG=None TEST=Build and boot to OS in Skyrim.
Change-Id: I4978a922744982afb231f8a9c650eedf950a507b Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com --- M src/soc/amd/cezanne/Kconfig M src/soc/amd/cezanne/Makefile.inc M src/soc/amd/common/Makefile.inc M src/soc/amd/common/block/psp/Kconfig M src/soc/amd/mendocino/Kconfig M src/soc/amd/mendocino/Makefile.inc M src/soc/amd/morgana/Kconfig M src/soc/amd/morgana/Makefile.inc M src/soc/amd/picasso/Kconfig M src/soc/amd/picasso/Makefile.inc M src/soc/amd/stoneyridge/Kconfig M src/soc/amd/stoneyridge/Makefile.inc 12 files changed, 85 insertions(+), 214 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/68584/4