Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33143 )
Change subject: Rampayload: Able to build coreboot without ramstage
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/33143/3/toolchain.inc
File toolchain.inc:
https://review.coreboot.org/#/c/33143/3/toolchain.inc@50
PS3, Line 50: ifeq ($(CONFIG_RAMPAYLOAD),y)
This shouldn't be necessary. Keeping ramstage in here doesn't hurt anyone if you don't use it. (verstage is also here despite being rarely used.)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33143
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id000dfac2eb57a8eaaa505c89d798fb30b3706fe
Gerrit-Change-Number: 33143
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Fri, 31 May 2019 21:44:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment