Rob Barnes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56667 )
Change subject: guybrush: Document USB mapping in devicetree ......................................................................
guybrush: Document USB mapping in devicetree
Add a short documenting comment to each usb entry in devicetree so it is clear which function each usb port maps to.
BUG=None TEST=Build BRANCH=None
Change-Id: I14cbb6af021bb27c89aa82456722f21aa09617be Signed-off-by: Rob Barnes robbarnes@google.com --- M src/mainboard/google/guybrush/variants/baseboard/devicetree.cb 1 file changed, 10 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/56667/1
diff --git a/src/mainboard/google/guybrush/variants/baseboard/devicetree.cb b/src/mainboard/google/guybrush/variants/baseboard/devicetree.cb index cf0f515..42f4991 100644 --- a/src/mainboard/google/guybrush/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/guybrush/variants/baseboard/devicetree.cb @@ -62,6 +62,7 @@
register "usb_phy_custom" = "1" register "usb_phy" = "{ + # USB C0 .Usb2PhyPort[0] = { .compdstune = 3, .sqrxtune = 3, @@ -73,6 +74,7 @@ .txhsxvtune = 3, .txrestune = 1, }, + # USB A0 or WWAN .Usb2PhyPort[1] = { .compdstune = 3, .sqrxtune = 3, @@ -84,6 +86,7 @@ .txhsxvtune = 3, .txrestune = 1, }, + # User facing camera .Usb2PhyPort[2] = { .compdstune = 1, .sqrxtune = 3, @@ -95,6 +98,7 @@ .txhsxvtune = 3, .txrestune = 2, }, + # World facing camera .Usb2PhyPort[3] = { .compdstune = 1, .sqrxtune = 3, @@ -106,6 +110,7 @@ .txhsxvtune = 3, .txrestune = 2, }, + # USB C1 .Usb2PhyPort[4] = { .compdstune = 3, .sqrxtune = 3, @@ -117,6 +122,7 @@ .txhsxvtune = 3, .txrestune = 1, }, + # USB A1 .Usb2PhyPort[5] = { .compdstune = 3, .sqrxtune = 3, @@ -128,6 +134,7 @@ .txhsxvtune = 3, .txrestune = 1, }, + # WiFi / Bluetooth .Usb2PhyPort[6] = { .compdstune = 1, .sqrxtune = 3, @@ -139,6 +146,7 @@ .txhsxvtune = 3, .txrestune = 2, }, + # Smart Card .Usb2PhyPort[7] = { .compdstune = 1, .sqrxtune = 3, @@ -150,7 +158,7 @@ .txhsxvtune = 3, .txrestune = 2, }, - + # USB C0 .Usb3PhyPort[0] = { .tx_term_ctrl=2, .rx_term_ctrl=2, @@ -169,6 +177,7 @@ .tx_vboost_lvl_en=1, .tx_vboost_lvl=5, }, + # USB C1 .Usb3PhyPort[3] = { .tx_term_ctrl=2, .rx_term_ctrl=2,