Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Angel Pons, Nick Vaccaro, EricR Lai.
Won Chung has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61803 )
Change subject: mb/google/var/agah: Use ACPI _PLD macro
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
oh, I mean for the port in the left/right, we can use acpi_pld_vertical_position. […]
When I check ACPI specification, front/back/left/right panels shall be viewed with the system resting on its bottom panel. So, I think vertical positions should indicate upper/center/lower positions.
https://uefi.org/specs/ACPI/6.4/06_Device_Configuration/Device_Configuration...
In this case, since we were considering just laptops, vertical position is not added and would be set to default (upper), but I think we can also add vertical position for chrome box.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61803
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idb8f30b2d1069aea1d5ce7c5dda7f99de33a7c26
Gerrit-Change-Number: 61803
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Won Chung
wonchung@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Thu, 10 Feb 2022 17:45:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment