[coreboot-gerrit] Change in coreboot[master]: mb/getac/p470/acpi: Convert 'battery.asl' to ASL 2.0 syntax

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45554 )

Change subject: mb/getac/p470/acpi: Convert 'battery.asl' to ASL 2.0 syntax
......................................................................

Patch Set 8:
> Patch Set 7:
> > Patch Set 7:
> > > Patch Set 7: Code-Review+1
> > >
> > > I think this looks correct.
> > >
> > > I think this overall ASL 2 conversion is a fantastic idea!
> > > But it's also amenable to automation...
> > > If I take a quick look in the coreboot source tree, I see:
> > > `git grep -c Store -- *.asl | wc -l`
> > > 327 .asl files that could use conversion to the new syntax.
> > >
> > > Food for thought 😊
> >
> > Honestly I have no idea how to make an automation. 
> > 'iasl -ca' cmd will not work.
>
> Things like "do not use 0x64 when calculating percentages" won't be caught by automation

Nope, but to be fair, it was already 100, so any automation wouldn't change that.