Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32770 )
Change subject: post_code: add post code for failure to load next stage ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/32770/3/src/include/console/post_codes.h File src/include/console/post_codes.h:
https://review.coreboot.org/#/c/32770/3/src/include/console/post_codes.h@324 PS3, Line 324: * Set if firmware failed to find or validate a resource that is stored in ROM.
Technically the boot media can be written on all platforms, using internal or external programmers. […]
Sorry, I'm not sure I understand what you're objecting to here. Are you objecting to calling the SPI ROM a ROM? Yeah, it can be updated but we call it ROM all over the place. Should we rename romstage for the same reason? flashstage maybe? This is getting a bit pedantic. :)
Typically when I hear "boot media" I think what the OS is booting from, not the BIOS.
https://review.coreboot.org/#/c/32770/3/src/lib/prog_loaders.c File src/lib/prog_loaders.c:
https://review.coreboot.org/#/c/32770/3/src/lib/prog_loaders.c@166 PS3, Line 166: die("Ramstage was not loaded!\n");
- You seem to mix ROM with romstage. […]
I agree with Patrick. coreboot is reading ramstage out of the ROM chip. This is the identical situation as loading romstage.