Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34765 )
Change subject: kohaku: add TEMP_SENSOR_3 and TEMP_SENSOR_4 to DPTF
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34765/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34765/1//COMMIT_MSG@11
PS1, Line 11: Note that this requires changes in both the EC and BIOS.
Probably good to add a Cq-Depend on the EC CL?
Done
https://review.coreboot.org/c/coreboot/+/34765/1/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/kohaku/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/34765/1/src/mainboard/google/hatch/...
PS1, Line 30: Thermal Sensor 3
The Hatch reference design gave these generic names. I'll revise them for Kohaku.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34765
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib8f38beae6392855927ce1249c229d7a114c72b2
Gerrit-Change-Number: 34765
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Aseda Aboagye
aaboagye@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Puthikorn Voravootivat
puthik@chromium.org
Gerrit-Reviewer: Seunghwan Kim
sh_.kim@samsung.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Comment-Date: Wed, 07 Aug 2019 19:36:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Fagerburg
pfagerburg@chromium.org
Comment-In-Reply-To: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment