[coreboot-gerrit] Change in ...coreboot[master]: mb/google/kahlee: Use GPIO_10 for EC_SYNC_IRQ

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31278 )

Change subject: mb/google/kahlee: Use GPIO_10 for EC_SYNC_IRQ
......................................................................

mb/google/kahlee: Use GPIO_10 for EC_SYNC_IRQ

Use AGPIO 10 as the EC sync interrupt for MKBP events for sensor data.

On this platform, interrupts are routed via the GPIO controller so need to be
registered using GpioInt instead of Interrupt.

BUG=b:123750725
BRANCH=grunt
TEST=MKBP events still received (with matching EC and kernel changes)

Change-Id: If499d24511bbaa7054207b7e0b98445723332c4f
Signed-off-by: Edward Hill 
Reviewed-on: https://review.coreboot.org/c/31278
Tested-by: build bot (Jenkins) 
Reviewed-by: Enrico Granata 
Reviewed-by: Raul Rangel 
Reviewed-by: Martin Roth 
---
M src/ec/google/chromeec/acpi/cros_ec.asl
M src/mainboard/google/kahlee/variants/aleena/include/variant/ec.h
M src/mainboard/google/kahlee/variants/aleena/include/variant/gpio.h
M src/mainboard/google/kahlee/variants/baseboard/gpio.c
4 files changed, 22 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Martin Roth: Looks good to me, approved
  Raul Rangel: Looks good to me, approved
  Enrico Granata: Looks good to me, but someone else must approve

diff --git a/src/ec/google/chromeec/acpi/cros_ec.asl b/src/ec/google/chromeec/acpi/cros_ec.asl
index a5f9202..d41071e 100644
--- a/src/ec/google/chromeec/acpi/cros_ec.asl
+++ b/src/ec/google/chromeec/acpi/cros_ec.asl
@@ -32,6 +32,17 @@
    })
 #endif

+#ifdef EC_ENABLE_SYNC_IRQ_GPIO
+	Name (_CRS, ResourceTemplate ()
+	{
+		GpioInt (Level, ActiveLow, Exclusive, PullDefault, 0x0000,
+		         "\_SB.GPIO", 0x00, ResourceConsumer, ,)
+		{
+			EC_SYNC_IRQ
+		}
+	})
+#endif
+
 #ifdef EC_ENABLE_MKBP_DEVICE
    Device (CKSC)
    {
diff --git a/src/mainboard/google/kahlee/variants/aleena/include/variant/ec.h b/src/mainboard/google/kahlee/variants/aleena/include/variant/ec.h
index e90724e..12c6de6 100644
--- a/src/mainboard/google/kahlee/variants/aleena/include/variant/ec.h
+++ b/src/mainboard/google/kahlee/variants/aleena/include/variant/ec.h
@@ -15,3 +15,9 @@

/* Enable EC backed Keyboard Backlight in ACPI */
 #define EC_ENABLE_KEYBOARD_BACKLIGHT
+
+/*
+ * Enable EC sync interrupt via GPIO controller, EC_SYNC_IRQ is defined in
+ * variant/gpio.h
+ */
+#define EC_ENABLE_SYNC_IRQ_GPIO
diff --git a/src/mainboard/google/kahlee/variants/aleena/include/variant/gpio.h b/src/mainboard/google/kahlee/variants/aleena/include/variant/gpio.h
index 5a6b540..3ddabb1 100644
--- a/src/mainboard/google/kahlee/variants/aleena/include/variant/gpio.h
+++ b/src/mainboard/google/kahlee/variants/aleena/include/variant/gpio.h
@@ -14,3 +14,6 @@
  */

#include <baseboard/gpio.h>
+
+/* EC sync irq is AGPIO 10 */
+#define EC_SYNC_IRQ	10
diff --git a/src/mainboard/google/kahlee/variants/baseboard/gpio.c b/src/mainboard/google/kahlee/variants/baseboard/gpio.c
index e9ae28c..9db26c7 100644
--- a/src/mainboard/google/kahlee/variants/baseboard/gpio.c
+++ b/src/mainboard/google/kahlee/variants/baseboard/gpio.c
@@ -117,8 +117,8 @@
    /* GPIO_8 - DDR_ALERT_3V3_L (currently not used) */
    PAD_GPI(GPIO_8, PULL_UP),

-	/* GPIO_10 - SLP_S0_L (currently not used) */
-	PAD_NF(GPIO_10, S0A3_GPIO, PULL_UP),
+	/* GPIO_10 - SLP_S0_L, EC_SYNC_IRQ */
+	PAD_GPI(GPIO_10, PULL_UP),

/* GPIO_11 - TOUCHSCREEN_INT_3V3_ODL, SCI */
    PAD_SCI(GPIO_11, PULL_UP, EDGE_LOW),