Attention is currently required from: Martin Roth, Karthik Ramasubramanian, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62500 )
Change subject: cpu/x86/smm: Add weak SoC init and exit methods
......................................................................
Patch Set 4:
(2 comments)
File src/include/cpu/x86/smm.h:
https://review.coreboot.org/c/coreboot/+/62500/comment/4af4845d_afb0758b
PS3, Line 54: early
Any relevance to add early?
Yeah, it's the convention we follow with bootblock. _early indicated before serial console is enabled.
https://review.coreboot.org/c/coreboot/+/62500/comment/55811b15_541c7d08
PS3, Line 55: void smm_mainboard_early_init(void);
: void smm_mainboard_exit(void);
Sure, we can add the mainboard methods later if we need them. I'll push up a new patch.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62500
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I946619cd62a974a98c575a92943b43ea639fc329
Gerrit-Change-Number: 62500
Gerrit-PatchSet: 4
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 08 Mar 2022 21:12:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment