Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39561 )
Change subject: src: Add '-Wduplicated-branches' warning option
......................................................................
Patch Set 22:
(1 comment)
Such warning options can produce a lot of noise, e.g. false
positives. Unless there was a serious bug in the past that
would have been discovered by this, I'd prefer _not_ to use
this option.
https://review.coreboot.org/c/coreboot/+/39561/20/src/vendorcode/amd/agesa/f...
File src/vendorcode/amd/agesa/f15tn/Proc/GNB/Modules/GnbInitTN/GfxIntegratedInfoTableTN.c:
https://review.coreboot.org/c/coreboot/+/39561/20/src/vendorcode/amd/agesa/f...
PS20, Line 188: ((Channel == 0) ? D18F2x94_dct0_ADDRESS : D18F2x94_dct1_ADDRESS),
What is the warning here? The code looks correct?
Maybe both types are just the same?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39561
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie433f32a423ce32ea2bd5ae09a1718341cd2b672
Gerrit-Change-Number: 39561
Gerrit-PatchSet: 22
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 16 Apr 2020 11:29:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment