build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59195 )
Change subject: WIP soc: Added dram information to cbmem WIP ......................................................................
Patch Set 1:
(80 comments)
File src/soc/qualcomm/common/qclib.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/fae039a8_0a379c78 PS1, Line 27: #if TEST_CODE /* Added this structure for testing purpose, will be remove once changes are reviewd */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/e3ab2d15_7c6dc4e2 PS1, Line 30: { open brace '{' following struct go on the same line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/27ac3bde_bf8aaa6b PS1, Line 31: uint64_t type; // enum that differentiates DDR3, LPDDR3, LPDDR4, etc. please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/8359daa1_333391b0 PS1, Line 32: uint64_t num_channels; // To know how may channels are available. please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/3b3e421f_4a9036ea PS1, Line 33: uint64_t reserved[6]; // Reserved [6] please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/851d6bfa_b4b2a7fc PS1, Line 34: struct please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/53bbbadc_5b6207a1 PS1, Line 35: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/91da5399_865e0c64 PS1, Line 35: { open brace '{' following struct go on the same line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/ec7d334b_f91cc901 PS1, Line 36: uint64_t density; // Total density Seen on channel code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/1673a5ab_aa5fce0d PS1, Line 36: uint64_t density; // Total density Seen on channel please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/02ead1b1_ef29502a PS1, Line 37: uint64_t io_width; // JEDEC MR8 - io width code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/3b881acd_5d83e3af PS1, Line 37: uint64_t io_width; // JEDEC MR8 - io width please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/825aec77_9a58d3eb PS1, Line 38: uint64_t manufacturer_id; // JEDEC MR5 code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/206a19d7_0bd5c073 PS1, Line 38: uint64_t manufacturer_id; // JEDEC MR5 please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/321a0e26_1e6571ee PS1, Line 39: uint64_t revision_id[2]; // JEDEC MR6, MR7 code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/6862f096_84a04760 PS1, Line 39: uint64_t revision_id[2]; // JEDEC MR6, MR7 please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/6e4b1a2d_1e884861 PS1, Line 40: uint64_t reserved[4]; // Reserved code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/df2ebca9_8cc6c1c3 PS1, Line 40: uint64_t reserved[4]; // Reserved please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/104c77a1_a6a0f2c2 PS1, Line 41: uint64_t serial_id[8]; // for potential future LPDDR5 expansion code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/71a23342_a96e856e PS1, Line 41: uint64_t serial_id[8]; // for potential future LPDDR5 expansion please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/707fee58_ea7a6525 PS1, Line 42: } channels[DDR_MAX_NUM_CH_TEST]; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/01cdb3e8_d6794858 PS1, Line 43: }dram_info; space required after that close brace '}'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/47391b56_3341e6ce PS1, Line 48: /* Save MEM CHIP info in SRAM region to share with ramstage */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/b43b885c_315dea76 PS1, Line 49: mem_chip_offset = (void *)te->blob_address; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/e3bb96ae_561c3307 PS1, Line 49: mem_chip_offset = (void *)te->blob_address; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/d7413119_1235c1bd PS1, Line 50: mem_chip_size = te->size; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/a033afcd_e8bcfd22 PS1, Line 50: mem_chip_size = te->size; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/a56fe37d_2c56fd40 PS1, Line 55: printk(BIOS_INFO, "%s:%s: Test Code to print memchip information before adding cbmem_add\n", __FILE__, __func__); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/01d6915d_fc10ed14 PS1, Line 56: memcpy(&memchip, (struct dram_info *)te->blob_address, sizeof(memchip)); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/6d6b193c_1c3b5cf3 PS1, Line 56: memcpy(&memchip, (struct dram_info *)te->blob_address, sizeof(memchip)); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/4b7d7fb4_83308f0f PS1, Line 57: printk(BIOS_INFO, "COREBOOT: MEM CHIP region offset: %p, size: %d\n", (void *)te->blob_address, (int)mem_chip_size); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/7e3fe7fd_da6f2dac PS1, Line 57: printk(BIOS_INFO, "COREBOOT: MEM CHIP region offset: %p, size: %d\n", (void *)te->blob_address, (int)mem_chip_size); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/0e724200_2d62dbd8 PS1, Line 57: printk(BIOS_INFO, "COREBOOT: MEM CHIP region offset: %p, size: %d\n", (void *)te->blob_address, (int)mem_chip_size); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/cf455f2f_ccfce561 PS1, Line 58: printk(BIOS_INFO, "COREBOOT: %s : %s : line:%d MEM CHIP : manufacturee_id : %lld \n", __FILE__, __func__, __LINE__, memchip.channels[0].manufacturer_id); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/cfd33e12_12eef5c8 PS1, Line 58: printk(BIOS_INFO, "COREBOOT: %s : %s : line:%d MEM CHIP : manufacturee_id : %lld \n", __FILE__, __func__, __LINE__, memchip.channels[0].manufacturer_id); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/b81a78d6_e322de4b PS1, Line 58: printk(BIOS_INFO, "COREBOOT: %s : %s : line:%d MEM CHIP : manufacturee_id : %lld \n", __FILE__, __func__, __LINE__, memchip.channels[0].manufacturer_id); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/ba7a642a_b77b5bd7 PS1, Line 58: printk(BIOS_INFO, "COREBOOT: %s : %s : line:%d MEM CHIP : manufacturee_id : %lld \n", __FILE__, __func__, __LINE__, memchip.channels[0].manufacturer_id); unnecessary whitespace before a quoted newline
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/e6e2eaf4_586157ba PS1, Line 59: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : density : %lld \n", __FILE__, __func__, memchip.channels[0].io_width); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/1c198298_75d1e049 PS1, Line 59: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : density : %lld \n", __FILE__, __func__, memchip.channels[0].io_width); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/7a99bc08_19aa204e PS1, Line 59: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : density : %lld \n", __FILE__, __func__, memchip.channels[0].io_width); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/5cad7504_8f03671e PS1, Line 59: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : density : %lld \n", __FILE__, __func__, memchip.channels[0].io_width); unnecessary whitespace before a quoted newline
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/05b810fc_38f52b28 PS1, Line 60: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : io-width : %lld \n", __FILE__, __func__, memchip.channels[0].density); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/ff551c12_48beeb63 PS1, Line 60: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : io-width : %lld \n", __FILE__, __func__, memchip.channels[0].density); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/7f79f89c_96ae44df PS1, Line 60: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : io-width : %lld \n", __FILE__, __func__, memchip.channels[0].density); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/28c7981a_fbe20658 PS1, Line 60: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : io-width : %lld \n", __FILE__, __func__, memchip.channels[0].density); unnecessary whitespace before a quoted newline
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/40cdb1c9_6f6f2490 PS1, Line 66: void *mem_region_base; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/e40bace1_84e2857b PS1, Line 66: void *mem_region_base; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/0df03514_415da94a PS1, Line 69: mem_region_base = cbmem_add(CBMEM_ID_MEM_CHIP_INFO, mem_chip_size); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/a18b5e83_8e23cd21 PS1, Line 69: mem_region_base = cbmem_add(CBMEM_ID_MEM_CHIP_INFO, mem_chip_size); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/99601c41_9d38b33d PS1, Line 70: ASSERT(mem_region_base != NULL); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/e3843c3c_9cb5f26b PS1, Line 70: ASSERT(mem_region_base != NULL); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/17cecb21_7693c71f PS1, Line 72: /* Migrate the data into CBMEM */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/58fe8cfa_99b6b446 PS1, Line 73: memcpy(mem_region_base, mem_chip_offset, mem_chip_size); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/618b6b39_14e2e1f7 PS1, Line 73: memcpy(mem_region_base, mem_chip_offset, mem_chip_size); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/ed1c0e7a_02eb2a5f PS1, Line 77: /* Test Code to print memchip information after adding cbmem_addd */ 'addd' may be misspelled - perhaps 'add'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/013dbf91_003d0eb8 PS1, Line 78: printk(BIOS_INFO, "%s:%s: Test Code to print memchip information after adding cbmem_add\n", __FILE__, __func__); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/d4267af6_971d4257 PS1, Line 80: printk(BIOS_INFO, "COREBOOT: MEM CHIP region offset: %p, size: %d\n", (void *)mem_region_base , (int)mem_chip_size); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/60847b5a_8fa5d3eb PS1, Line 80: printk(BIOS_INFO, "COREBOOT: MEM CHIP region offset: %p, size: %d\n", (void *)mem_region_base , (int)mem_chip_size); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/051dc19c_186fcbf5 PS1, Line 80: printk(BIOS_INFO, "COREBOOT: MEM CHIP region offset: %p, size: %d\n", (void *)mem_region_base , (int)mem_chip_size); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/4518ffef_33d323bd PS1, Line 80: printk(BIOS_INFO, "COREBOOT: MEM CHIP region offset: %p, size: %d\n", (void *)mem_region_base , (int)mem_chip_size); space prohibited before that ',' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/80505a27_ba03ea3a PS1, Line 81: printk(BIOS_INFO, "COREBOOT: %s : %s : line:%d MEM CHIP : manufacturee_id : %lld \n", __FILE__, __func__, __LINE__, memchip.channels[0].manufacturer_id); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/1e9309a4_f3c6dbb9 PS1, Line 81: printk(BIOS_INFO, "COREBOOT: %s : %s : line:%d MEM CHIP : manufacturee_id : %lld \n", __FILE__, __func__, __LINE__, memchip.channels[0].manufacturer_id); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/ef8e188c_c885a029 PS1, Line 81: printk(BIOS_INFO, "COREBOOT: %s : %s : line:%d MEM CHIP : manufacturee_id : %lld \n", __FILE__, __func__, __LINE__, memchip.channels[0].manufacturer_id); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/a4a4fbec_3b107a9c PS1, Line 81: printk(BIOS_INFO, "COREBOOT: %s : %s : line:%d MEM CHIP : manufacturee_id : %lld \n", __FILE__, __func__, __LINE__, memchip.channels[0].manufacturer_id); unnecessary whitespace before a quoted newline
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/da93b019_8468a704 PS1, Line 82: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : density : %lld \n", __FILE__, __func__, memchip.channels[0].io_width); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/b849a26c_346e7cb2 PS1, Line 82: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : density : %lld \n", __FILE__, __func__, memchip.channels[0].io_width); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/5f5031e1_581148b6 PS1, Line 82: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : density : %lld \n", __FILE__, __func__, memchip.channels[0].io_width); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/9128cd80_a535669c PS1, Line 82: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : density : %lld \n", __FILE__, __func__, memchip.channels[0].io_width); unnecessary whitespace before a quoted newline
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/a4431cad_0885e31a PS1, Line 83: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : io-width : %lld \n", __FILE__, __func__, memchip.channels[0].density); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/dfdaf51f_eb6ab805 PS1, Line 83: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : io-width : %lld \n", __FILE__, __func__, memchip.channels[0].density); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/ed1adaf9_6fc6ffaa PS1, Line 83: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : io-width : %lld \n", __FILE__, __func__, memchip.channels[0].density); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/4f7d98a6_970d2f38 PS1, Line 83: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : io-width : %lld \n", __FILE__, __func__, memchip.channels[0].density); unnecessary whitespace before a quoted newline
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/9b252f95_1679eaa7 PS1, Line 157: sizeof(te->name))) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/cef8b2fa_cab1f483 PS1, Line 157: sizeof(te->name))) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/e99d5aa3_a5b6393d PS1, Line 158: write_mem_chip_information(te); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/06d548dc_ad42bc30 PS1, Line 158: write_mem_chip_information(te); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/8d2802fb_b37053d9 PS1, Line 213: qclib_add_if_table_entry(QCLIB_TE_MEM_CHIP_INFO, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/a6cf87a6_4a2883c2 PS1, Line 213: qclib_add_if_table_entry(QCLIB_TE_MEM_CHIP_INFO, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/a9df5d6d_fdc57b7d PS1, Line 214: _mem_chip_info, REGION_SIZE(mem_chip_info), 0); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133031): https://review.coreboot.org/c/coreboot/+/59195/comment/de7585f6_6aa97b48 PS1, Line 214: _mem_chip_info, REGION_SIZE(mem_chip_info), 0); please, no spaces at the start of a line