chris wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42215 )
Change subject: vc/amd/fsp/picasso:Add xhci0_force_gen1 parameter to AGESA FSP-S UPD ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/42215/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42215/1//COMMIT_MSG@7 PS1, Line 7: Add xhci0_force_gen1 parameter to AGESA FSP-S UPD
Please add a prefix.
Done
https://review.coreboot.org/c/coreboot/+/42215/1//COMMIT_MSG@9 PS1, Line 9: add xhci0_force_gen1 parameter for force xhci0 to gen1
Please start with a capital letter and add a dot/period at the end.
Done
https://review.coreboot.org/c/coreboot/+/42215/1//COMMIT_MSG@10 PS1, Line 10:
Is there only one xHCI controller?
only for xhci0
https://review.coreboot.org/c/coreboot/+/42215/1//COMMIT_MSG@13 PS1, Line 13: TEST=Build, verified the device speed been forced to gen 1 on Trembyle.
How did you verify that?
verified with a USB3 Gen2 device and check the speed was been limited to Gen1.