Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41729 )
Change subject: soc/intel/tigerlake: Select PLATFORM_USES_FSP2_2 ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41729/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41729/6//COMMIT_MSG@10 PS6, Line 10: FSP2.2
Please add space between "FSP" and "2. […]
Done
https://review.coreboot.org/c/coreboot/+/41729/6/src/soc/intel/tigerlake/fsp... File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/41729/6/src/soc/intel/tigerlake/fsp... PS6, Line 322: TODO
Please file a bug for the TODO and remove "TODO:" from the comment, perhaps change comment to "TCSS […]
Ack