Attention is currently required from: Ashish Kumar Mishra, Saurabh Mishra.
Balaji Manigandan has posted comments on this change by Balaji Manigandan. ( https://review.coreboot.org/c/coreboot/+/83887?usp=email )
Change subject: Fix no-op for empty arg in Makefile for Bash 5.2.21 ......................................................................
Patch Set 2:
(7 comments)
Patchset:
PS2: Fixed the comments from checkpatch
Commit Message:
https://review.coreboot.org/c/coreboot/+/83887/comment/54e74fd3_b85dadad?usp... : PS1, Line 15: The error was triggered by an empty third argument `$(3)` in a conditional
`Possible unwrapped commit description (prefer a maximum 72 chars per line)`
Please fix.
https://review.coreboot.org/c/coreboot/+/83887/comment/94a717d1_c687a09f?usp... : PS1, Line 16: `$(if ...)` statement. The original line did not specify an explicit no-op
`Possible unwrapped commit description (prefer a maximum 72 chars per line)`
Please fix.
https://review.coreboot.org/c/coreboot/+/83887/comment/4e20d7ea_34e72b3f?usp... : PS1, Line 17: for the case when `$(3)` is empty, which led to the execution of an incomplete
`Possible unwrapped commit description (prefer a maximum 72 chars per line)`
Please fix.
https://review.coreboot.org/c/coreboot/+/83887/comment/a4f28f93_3e4d58ae?usp... : PS1, Line 20: By adding a colon `:` as a no-op command in the else-part of the `$(if ...)`,
`Possible unwrapped commit description (prefer a maximum 72 chars per line)`
Please fix.
https://review.coreboot.org/c/coreboot/+/83887/comment/74027ed4_eec694ce?usp... : PS1, Line 21: we ensure that a harmless command is executed when `$(3)` is empty, preventing
`Possible unwrapped commit description (prefer a maximum 72 chars per line)`
Please fix.
https://review.coreboot.org/c/coreboot/+/83887/comment/d7726f27_4b077f0c?usp... : PS1, Line 24: This fix ensures compatibility with the newer Bash version and prevents the
`Possible unwrapped commit description (prefer a maximum 72 chars per line)`
Please fix.