Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35481 )
Change subject: soc/mediatek/mt8183: Clean cached calibration results if mem test fails ......................................................................
Patch Set 45:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35481/45/src/soc/mediatek/mt8183/me... File src/soc/mediatek/mt8183/memory.c:
https://review.coreboot.org/c/coreboot/+/35481/45/src/soc/mediatek/mt8183/me... PS45, Line 160: 0 use 0xff, which is the native uninitialized data on SPI flash.
BTW, I wonder if we should do this now.
If this fails, we'll go "run full calibration", and it should write a new calibration data if success, so clearing to zero now is not needed.
So will it make more sense to always clear when full calibration failed? (step further, we may consider having a special STATUS indicating we can stop testing full calib until next version).