Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34157 )
Change subject: soc/intel/cannonlake: Add device Ids for new CFL SKUs support
......................................................................
Patch Set 15:
Generally, these things are much easier to review and to get merged,
when you break it down to smaller commits. If there is a list in the
commit messages, that's always a sign that it could be broken down
easily. 90% of this change is ready for merge, but hold back by the
other 10% (that most likely never will be merged, so a lot of time
is wasted).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34157
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I343b11ea8d9c33eb189d7478511a473b145f4ab4
Gerrit-Change-Number: 34157
Gerrit-PatchSet: 15
Gerrit-Owner: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Boon Tiong Teo
boon.tiong.teo@intel.com
Gerrit-Reviewer: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Comment-Date: Fri, 12 Jul 2019 09:03:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment