Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44148 )
Change subject: mb/google/dedede/variants/drawcia: add DTT support
......................................................................
Patch Set 8: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/44148/7/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/drawcia/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44148/7/src/mainboard/google/dedede...
PS7, Line 43: ,
Once DPTF begins, if temperature allows, it can drive PL1 up to 4. […]
It seems MSR_PKG_POWER_SKU_UNIT can be configured to some mW. But I am not finding the description of that MSR in any of the documents I have access to.
May not be for this CL. But is it possible to look into it in a follow-up CL?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44148
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If50052864fb246a6a8f7d96fa50529e5f55968c0
Gerrit-Change-Number: 44148
Gerrit-PatchSet: 8
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 07 Aug 2020 18:17:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment