18 Oct
2019
18 Oct
'19
12:28 p.m.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36101 )
Change subject: util/ifdtool: Add support for setting flash density on IFD V2 ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36101/3/util/ifdtool/ifdtool.c File util/ifdtool/ifdtool.c:
https://review.coreboot.org/c/coreboot/+/36101/3/util/ifdtool/ifdtool.c@942 PS3, Line 942: chip2_offset = 3;
If anyone has the time: It would be a good idea to extract the IFD code from flashrom into a common library.
Could you put that in Documentation/contributing/project_ideas.md?
--
To view, visit https://review.coreboot.org/c/coreboot/+/36101
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc3e4c197f99f99007cb208cf6cc4ae6f56be70c
Gerrit-Change-Number: 36101
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: Stefan T stefan.tauner@gmx.at
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Patrick Georgi pgeorgi@google.com
Gerrit-Comment-Date: Fri, 18 Oct 2019 12:28:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment