16 Nov
2022
16 Nov
'22
3:31 a.m.
Attention is currently required from: Nico Huber, Angel Pons.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69670 )
Change subject: nb/intel/ironlake,sandybridge/gma: Fix out() parameter order ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Note, haswell/gma has a similar issue even going down into enable_tco_sci()...
I have tco_read/write_reg() in my local queue waiting. But if you spotted errors with out() alone I'll fix them first.
--
To view, visit https://review.coreboot.org/c/coreboot/+/69670
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4baa2e06d336736caf5505a05ed4353bcbfdb517
Gerrit-Change-Number: 69670
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 16 Nov 2022 11:31:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment