Attention is currently required from: Christian Walter, Julius Werner, Tim Crawford.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75997?usp=email )
Change subject: UNTESTED: security/crtm: Don't measure anything on S3 resume
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS2:
This is causing a full boot but still somehow reporting it as S3 Resume.
Here is the log from system76/oryp11: https://dpaste.org/NMYjV
Note: This is still on a 4.19 base.
I'm not sure I understand. Is a cold boot being reported as S3 resume?
Latest CL should now skip creating a digest on S3 resume.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75997?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic4ed5a3ca8bb2f82931e08348754c173d7a78c53
Gerrit-Change-Number: 75997
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Thu, 22 Jun 2023 09:27:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Crawford
tcrawford@system76.com
Gerrit-MessageType: comment