Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, John Zhao. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56024 )
Change subject: drivers/usb/acpi: Create function to get PLD information ......................................................................
Patch Set 2:
(3 comments)
File src/drivers/usb/acpi/usb_acpi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123195): https://review.coreboot.org/c/coreboot/+/56024/comment/3ca58c75_6a77ec53 PS2, Line 57: printk(BIOS_ERR,"Error retrieving PLD for %s \n", path); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123195): https://review.coreboot.org/c/coreboot/+/56024/comment/21e87213_4ad8caa5 PS2, Line 57: printk(BIOS_ERR,"Error retrieving PLD for %s \n", path); unnecessary whitespace before a quoted newline
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123195): https://review.coreboot.org/c/coreboot/+/56024/comment/bfb5aae4_aee1991e PS2, Line 131: if (!usb_device || !usb_device->chip_info || \ Avoid unnecessary line continuations