[coreboot-gerrit] [L] Change in coreboot[main]: soc/mediatek/mt8196: Add EINT support

[Yu-Ping Wu (Code Review)]

Attention is currently required from: Hung-Te Lin, Jarried Lin.

Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84026?usp=email )

Change subject: soc/mediatek/mt8196: Add EINT support
......................................................................

Patch Set 16:

(7 comments)

File src/soc/mediatek/mt8196/gpio_eint.c:

https://review.coreboot.org/c/coreboot/+/84026/comment/998e0a85_df3b5710?usp... :
PS16, Line 11: #define EINT_DUMMY	0
Use enum.

https://review.coreboot.org/c/coreboot/+/84026/comment/fb678592_11aa7d84?usp... :
PS16, Line 11: DUMMY
INVALID

https://review.coreboot.org/c/coreboot/+/84026/comment/e55d85ef_98d8abfc?usp... :
PS16, Line 267: 
Add `uint8_t index = eint_data[idx].index`.

https://review.coreboot.org/c/coreboot/+/84026/comment/aca7e903_4201cc8a?usp... :
PS16, Line 275: void *
uintptr_t

https://review.coreboot.org/c/coreboot/+/84026/comment/4081e435_667d2e75?usp... :
PS16, Line 282: (void *)
Remove

https://review.coreboot.org/c/coreboot/+/84026/comment/eebf7421_1146f282?usp... :
PS16, Line 297: 		addr = NULL;
Print an error and return NULL. Is this considered an error?

https://review.coreboot.org/c/coreboot/+/84026/comment/48410ab8_a93480bb?usp... :
PS16, Line 301: addr
`(void *)addr`