Jonathan Zhang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45592 )
Change subject: mb/ocp/deltalake: add LPC device entry in ACPI ......................................................................
mb/ocp/deltalake: add LPC device entry in ACPI
PCH LPC device is on CSTACK. Add LPC ACPI device entry.
Without this change, following error message shows up in target OS boot log: ACPI BIOS Error (bug): Failure looking up [_SB.PCI0.LPCB], AE_NOT_FOUND (20180105/dswload-211) ACPI Error: AE_NOT_FOUND, During name lookup/catalog (20180105/psobject-252) ACPI Error: AE_NOT_FOUND, (SSDT:COREBOOT) while loading table (20180105/tbxfload-228) ACPI Error: 1 table load failures, 1 successful (20180105/tbxfload-246)
Also TPM device is not created.
TESTED=Booted DeltaLake DVT, run following command in target OS: [root@dhcp-100-96-192-153 ~]# dmesg | grep tpm [ 7.331890] tpm_tis MSFT0101:00: 2.0 TPM (device-id 0x1B, rev-id 16)
Signed-off-by: Jonathan Zhang jonzhang@fb.com Change-Id: I8614f6951389bd5c8f8f33522d0a9a9160ac3f66 --- M src/mainboard/ocp/deltalake/dsdt.asl 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/45592/1
diff --git a/src/mainboard/ocp/deltalake/dsdt.asl b/src/mainboard/ocp/deltalake/dsdt.asl index c74b5fe..4d784f3 100644 --- a/src/mainboard/ocp/deltalake/dsdt.asl +++ b/src/mainboard/ocp/deltalake/dsdt.asl @@ -20,4 +20,10 @@
// CPX-SP ACPI tables #include <soc/intel/xeon_sp/cpx/acpi/uncore.asl> + + // LPC related entries + Scope (_SB.PC00) + { + #include <soc/intel/common/block/acpi/acpi/lpc.asl> + } }