Attention is currently required from: Joel Kitching, Roger Lu, Yidi Lin, Yu-Ping Wu, Yuchen Huang.
Ran Bi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46878 )
Change subject: soc/mediatek/mt8192: add clkbuf and srclken_rc MT6359P driver
......................................................................
Patch Set 66:
(2 comments)
File src/soc/mediatek/mt8192/srclken_rc.c:
https://review.coreboot.org/c/coreboot/+/46878/comment/3ffe8539_e1f780a4
PS64, Line 365: retry--
maybe we can use stopwatch API to make it more clear ?
Done
File src/soc/mediatek/mt8192/srclken_rc.c:
https://review.coreboot.org/c/coreboot/+/46878/comment/822cd42d_1a8ea845
PS65, Line 374: break
@Ran, do we need to poll remaining channels if current channel is timed out ?
Removed
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46878
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I947bf14df7a307bf359c590c2a20265882b3f1be
Gerrit-Change-Number: 46878
Gerrit-PatchSet: 66
Gerrit-Owner: Roger Lu
roger.lu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Ran Bi
ran.bi@mediatek.com
Gerrit-Reviewer: Roger Lu
roger.lu@mediatek.com
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Yuchen Huang
yuchen.huang@mediatek.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: hsin-hsiung wang
hsin-hsiung.wang@mediatek.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Joel Kitching
kitching@google.com
Gerrit-Attention: Roger Lu
roger.lu@mediatek.corp-partner.google.com
Gerrit-Attention: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Yuchen Huang
yuchen.huang@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Mon, 18 Jan 2021 03:03:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ran Bi
ran.bi@mediatek.com
Comment-In-Reply-To: Yidi Lin
yidi.lin@mediatek.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment