Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/83927?usp=email )
Change subject: soc/mediatek/mt8196: Add I2C driver support
......................................................................
Patch Set 8:
(2 comments)
File src/soc/mediatek/mt8196/include/soc/i2c.h:
https://review.coreboot.org/c/coreboot/+/83927/comment/39fd124c_a107e8b8?usp... :
PS8, Line 46: */
space
https://review.coreboot.org/c/coreboot/+/83927/comment/60c6284d_d3f416f1?usp... :
PS8, Line 67: (
No need for `()`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83927?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I617ad8a43ce8b492b1a0e5dc06c1f0ffe7d92b5e
Gerrit-Change-Number: 83927
Gerrit-PatchSet: 8
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: ot_hao.han@mediatek.com
ot_hao.han@mediatek.corp-partner.google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Mon, 19 Aug 2024 02:24:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No