[coreboot-gerrit] Change in coreboot[master]: util/cbfstool: Replace swab.h with commonlib/bsd/sysincludes.h

[Alex James (Code Review)]

Attention is currently required from: Angel Pons, Julius Werner.
Alex James has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60233 )

Change subject: util/cbfstool: Replace swab.h with commonlib/bsd/sysincludes.h
......................................................................

Patch Set 7:

(3 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/60233/comment/e86dae9f_f11f35a4 
PS6, Line 12: ntohl/ntohll instead be32toh/be64toh
> be32toh/be64toh instead of ntohl/ntohll […]

Thanks! I updated the commit message.

File util/cbfstool/cbfs_image.c:

https://review.coreboot.org/c/coreboot/+/60233/comment/0f0ffb1e_83374943 
PS6, Line 528: uint32_t type = htobe32(cur->type);
             : 
             : 		/* Current entry is empty. Kepp track of it. */
             : 		if ((type == htobe32(CBFS_TYPE_NULL)) ||
             : 		    (type == htobe32(CBFS_TYPE_DELETED))) {
> This looks very stupid

Yeah...

https://review.coreboot.org/c/coreboot/+/60233/comment/30072ae8_5149a1d9 
PS6, Line 1031: be32toh(stage->loadaddr)
> I wonder why this is interpreted as a 32-bit value here, it was interpreted as a 64-bit value before […]

Seems like a mistake? be64toh(stage->loadaddr) is used everywhere else in this file.