Attention is currently required from: Sean Rhodes, Jeremy Soller, Tim Wawrzynczak, Angel Pons, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56256 )
Change subject: src/soc/intel/*: Change legacy_8254_timer to CMOS option ......................................................................
Patch Set 2:
(3 comments)
File src/soc/intel/cannonlake/fsp_params.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123945): https://review.coreboot.org/c/coreboot/+/56256/comment/a7f66cda_091b2ca1 PS2, Line 431: params->Enable8254ClockGating = !legacy_8254_timer;; Statements terminations use 1 semicolon
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123945): https://review.coreboot.org/c/coreboot/+/56256/comment/8875a14b_821aaab4 PS2, Line 432: params->Enable8254ClockGatingOnS3 = !legacy_8254_timer;; Statements terminations use 1 semicolon
File src/soc/intel/jasperlake/fsp_params.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123945): https://review.coreboot.org/c/coreboot/+/56256/comment/55432b4c_e40e9e6e PS2, Line 91: params->Enable8254ClockGating = !legacy_8254_timer;; Statements terminations use 1 semicolon