Attention is currently required from: Tim Wawrzynczak, Eric Lai.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62722 )
Change subject: mb/google/nissa/var/nivviks: Add GL9750 power sequence
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
File src/mainboard/google/brya/variants/nivviks/gpio.c:
https://review.coreboot.org/c/coreboot/+/62722/comment/c22c6ca0_e12bab34
PS1, Line 35: PAD_CFG_GPO(GPP_H12, 0, DEEP),
nit: could you please move this down to keep them sorted?
https://review.coreboot.org/c/coreboot/+/62722/comment/d545369d_cb853a55
PS1, Line 56: PAD_CFG_GPO(GPP_H12, 1, DEEP)
Not objecting to moving to ramstage if it works, but I also think romstage would be safer choice in […]
Ok, that makes sense. I'm happy to leave it in romstage. Although I wonder why it does work with ramstage too then.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62722
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib6d461a56f6aeba30994daafe8993c36df4b309d
Gerrit-Change-Number: 62722
Gerrit-PatchSet: 1
Gerrit-Owner: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Thu, 10 Mar 2022 03:12:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Kangheui Won
khwon@chromium.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Reka Norman
rekanorman@chromium.org
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment