Yuchen He has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76036?usp=email )
Change subject: mb/{cfl,cml,whl}: Use true/false macros for DdiPortFDdc dt option ......................................................................
mb/{cfl,cml,whl}: Use true/false macros for DdiPortFDdc dt option
The true/false macros give the reader a better understanding about how the option should be used. Thus, replace 0/1 with false/true.
While on it, remove the quotes from the option name and from the value.
Coffeelake, Cometlake and Whiskeylake mainboards which use that option were changed by the following command ran from the top level directory.
dt_line="chip soc/intel/cannonlake" && \ option="DdiPortFDdc" && \ grep -r "${dt_line}" src/mainboard | \ cut -d ':' -f 1 | \ xargs sed -i'' -e "s/"${option}".*=.*"1"/${option} = true/g" -e "s/"${option}".*=.*"0"/${option} = false/g"
Change-Id: Iddd021d8aec1cf3e8c3bbbe3221b27df3ea82d61 Signed-off-by: lilacious yuchenhe126@gmail.com --- M src/mainboard/intel/coffeelake_rvp/variants/cml_u/overridetree.cb M src/mainboard/intel/coffeelake_rvp/variants/whl_u/overridetree.cb 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/76036/1
diff --git a/src/mainboard/intel/coffeelake_rvp/variants/cml_u/overridetree.cb b/src/mainboard/intel/coffeelake_rvp/variants/cml_u/overridetree.cb index aaf0349..b7d89cd 100644 --- a/src/mainboard/intel/coffeelake_rvp/variants/cml_u/overridetree.cb +++ b/src/mainboard/intel/coffeelake_rvp/variants/cml_u/overridetree.cb @@ -13,7 +13,7 @@ register DdiPortBDdc = true register DdiPortCDdc = true register DdiPortDDdc = true - register "DdiPortFDdc" = "1" + register DdiPortFDdc = true
register "SerialIoDevMode" = "{ [PchSerialIoIndexI2C0] = PchSerialIoPci, diff --git a/src/mainboard/intel/coffeelake_rvp/variants/whl_u/overridetree.cb b/src/mainboard/intel/coffeelake_rvp/variants/whl_u/overridetree.cb index eec7c79..8450306 100644 --- a/src/mainboard/intel/coffeelake_rvp/variants/whl_u/overridetree.cb +++ b/src/mainboard/intel/coffeelake_rvp/variants/whl_u/overridetree.cb @@ -13,7 +13,7 @@ register DdiPortBDdc = true register DdiPortCDdc = true register DdiPortDDdc = true - register "DdiPortFDdc" = "1" + register DdiPortFDdc = true
register SataSalpSupport = true register "SataPortsEnable[0]" = "1"