Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34529 )
Change subject: soc/nvidia/tegra210: Prevent implicit integer promotion ......................................................................
Patch Set 1: Code-Review+2
Hmmmm, I didn't know about that and that's a good point. In this case though things are slightly worse, since tegra_dsi_writel() expects a 64 bit integer for that argument, and if it's negative it will be sign extended to a very large unsigned integer. In this case, tegra_dsi_writel() only needs to write a 32 bit integer, so I think I'll change the argument to a u32 instead to avoid the sign extension.
Okay, the sign extension is a valid concern. Your suggestion sounds good, or I'd also be fine with the original CL in that case.