[coreboot-gerrit] Change in coreboot[master]: drivers/intel/fsp2_0/include/fsp: fix fsp_header

[Name of user not set (Code Review)]

Attention is currently required from: Jason Glenesk, Raul Rangel, Subrata Banik, Marshall Dawson, Tim Wawrzynczak, Paul Menzel, Andrey Petrov, Julian Schroeder, Patrick Rudolph, Felix Held.
Name of user not set #1003801 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58869 )

Change subject: drivers/intel/fsp2_0/include/fsp: fix fsp_header
......................................................................

Patch Set 9:

(6 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/58869/comment/770ada10_f694033e 
PS8, Line 8:
> Please describe the problem (caused by unaligned FSP header). […]

Ack

File src/drivers/intel/fsp2_0/header_display.c:

https://review.coreboot.org/c/coreboot/+/58869/comment/2eaaa132_e96c6182 
PS8, Line 28: %s
> this probably needs to be %. […]

Ack

https://review.coreboot.org/c/coreboot/+/58869/comment/6cda90b8_6d62dc46 
PS8, Line 29: hdr->image_id
> this is no longer a zero terminated c string, so you need to adjust the printk format specifier to o […]

Ack

File src/drivers/intel/fsp2_0/include/fsp/info_header.h:

https://review.coreboot.org/c/coreboot/+/58869/comment/a5abc2ae_5249025d 
PS8, Line 29: api_entry_num
> this should probably be res2. a change from the fsp info header block from the fsp 1.1 to fsp 2. […]

Ack

File src/drivers/intel/fsp2_0/include/fsp/info_header.h:

https://review.coreboot.org/c/coreboot/+/58869/comment/da521f19_90c489d9 
PS7, Line 30: temp
> The version of the spec I have indeed only has the […]

Ack

File src/drivers/intel/fsp2_0/util.c:

https://review.coreboot.org/c/coreboot/+/58869/comment/10054c49_1fc5a1cb 
PS8, Line 54: 	if (!looks_like_fsp_header(raw_hdr))
> i'd pass a struct fsp_header to looks_like_fsp_header instead of the raw binary to avoid using hard- […]

Ack