Attention is currently required from: Alexander Couzens, Nicholas Chin, Nicholas Sudsgaard, Nico Huber, Paul Menzel.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80343?usp=email )
Change subject: mainboard/lenovo: Add ThinkCentre M710s (Skylake)
......................................................................
Patch Set 15: Code-Review+2
(2 comments)
File src/mainboard/lenovo/thinkcentre_m710s/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/80343/comment/f1a3a2bb_9f0c64b2 :
PS8, Line 2: # Model: IB250MH
Placed it in `board_info.txt` instead.
Sorry, for the long silence. That makes sense. Thanks!
File src/mainboard/lenovo/thinkcentre_m710s/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/80343/comment/dd3cab16_5f53f2de :
PS15, Line 46: register "SataMode" = "SATA_AHCI"
AHCI is the default, remove.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80343?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I551753aecfbd2c0ee57d85bb22cb943eb21af3cc
Gerrit-Change-Number: 80343
Gerrit-PatchSet: 15
Gerrit-Owner: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-Attention: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Comment-Date: Wed, 21 Feb 2024 05:23:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-MessageType: comment