Attention is currently required from: Pranava Y N, Subrata Banik, Tongtong Pan, Weimin Wu.
Paul Menzel has posted comments on this change by Tongtong Pan. ( https://review.coreboot.org/c/coreboot/+/85287?usp=email )
Change subject: mb/google/fatcat: Modify felino variant
......................................................................
Patch Set 6:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85287/comment/fffeb54b_108f7ff0?usp... :
PS6, Line 7: Modify felino variant
Please split the commit into smaller commits (Kconfig, memory, overridetree, …).
https://review.coreboot.org/c/coreboot/+/85287/comment/897a4607_2711bb58?usp... :
PS6, Line 9: Modify the kconfig file to successfully compile felino,
Is the build currently broken? Please make it a separate/dedicated commit.
https://review.coreboot.org/c/coreboot/+/85287/comment/16e56649_c32ae721?usp... :
PS6, Line 9: ,
.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85287?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iaaefd6cb5b879666eca4dcba5d77d2ed7a11eeb1
Gerrit-Change-Number: 85287
Gerrit-PatchSet: 6
Gerrit-Owner: Tongtong Pan
pantongtong@huaqin.corp-partner.google.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Dolan Liu
liuyong5@huaqin.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Attention: Tongtong Pan
pantongtong@huaqin.corp-partner.google.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Tue, 26 Nov 2024 07:52:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No