Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45740 )
Change subject: drivers/spi: Add BOOT_DEVICE_SPI_FLASH_NO_EARLY_WRITES config ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/c/coreboot/+/45740/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45740/1//COMMIT_MSG@10 PS1, Line 10: don't do mmapping but still want to use the do not allow write to SPI flash when early stages are running XIP from the flash.
https://review.coreboot.org/c/coreboot/+/45740/1//COMMIT_MSG@11 PS1, Line 11: cbmem to store the mrc_cache data in order to write the mrc_cache data : back at a later time Also, if this config is not selected, BOOT_DEVICE_SPI_FLASH_NO_EARLY_WRITES gets auto-selected which means all future platforms don't need to worry about selecting BOOT_DEVICE_SPI_FLASH_NO_EARLY_WRITES. This is under the assumption that most platforms going forward would be fine doing writes to SPI flash even in early stages.
https://review.coreboot.org/c/coreboot/+/45740/1//COMMIT_MSG@15 PS1, Line 15: Also, mention that BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY selection is dropped from current platforms as this config is getting auto-selected.
https://review.coreboot.org/c/coreboot/+/45740/1//COMMIT_MSG@18 PS1, Line 18: ./util/abuild/abuild -p none -t GOOGLE_NAMI -x -a I think it would be good to check builds for the platforms for which the config change is being made using the timeless option. It will allow you to confirm that there are no functional changes because of this CL.
https://review.coreboot.org/c/coreboot/+/45740/1/src/drivers/spi/Kconfig File src/drivers/spi/Kconfig:
https://review.coreboot.org/c/coreboot/+/45740/1/src/drivers/spi/Kconfig@50 PS1, Line 50: For x86 platforms who do not include the boot_device_rw_nommap libraries I think we should say that this config is used by platforms that do not allow writes to SPI flash in early stages. No need to mention x86 here. Also, we should indicate that not selecting this config results in auto-selection of BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY if BOOT_DEVICE_SPI_FLASH_RW_NOMMAP is selected by the platform.