Attention is currently required from: Tarun Tuli, Jamie Ryu, Subrata Banik, Ravishankar Sarawadi, Kapil Porwal.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69577 )
Change subject: soc/intel/meteorlake: Update CSE firmware status registers
......................................................................
Patch Set 3:
(3 comments)
File src/soc/intel/meteorlake/me.c:
https://review.coreboot.org/c/coreboot/+/69577/comment/9d31b9f6_b5357636
PS1, Line 55: uint32_t btg_profile : 1;
It is a 3-bit field as per the doc.
Good catch!
https://review.coreboot.org/c/coreboot/+/69577/comment/39ccd56d_99472f94
PS1, Line 59: uint32_t bsp_bpm_exe_sts : 4;
1-bit field
Ack
https://review.coreboot.org/c/coreboot/+/69577/comment/a5a6e201_26459e9e
PS1, Line 60: uint32_t btg_token_applied : 4;
1-bit field
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69577
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibee9a0955efc22ea0d9fdbba2d09e57d8851e22e
Gerrit-Change-Number: 69577
Gerrit-PatchSet: 3
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Tue, 15 Nov 2022 04:57:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kapil Porwal
kapilporwal@google.com
Gerrit-MessageType: comment