Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31329 )
Change subject: vboot: copy data structures to CBMEM for downstream use
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/31329/5/src/include/symbols.h
File src/include/symbols.h:
https://review.coreboot.org/#/c/31329/5/src/include/symbols.h@128
PS5, Line 128: pre_ram_
nit: I think "preram" without underscore has a little more precedence, e.g. in things like _preram_cbmem_console.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31329
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I62c11268a83927bc00ae9bd93b1b31363b38e8cf
Gerrit-Change-Number: 31329
Gerrit-PatchSet: 5
Gerrit-Owner: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Randall Spangler
rspangler@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 21 Feb 2019 00:01:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment