Attention is currently required from: Angel Pons, Dinesh Gehlot, Jayvik Desai, Paul Menzel.
Subrata Banik has posted comments on this change by Jayvik Desai. ( https://review.coreboot.org/c/coreboot/+/83705?usp=email )
Change subject: vc/google/chromeos: Enable eSOL config with libgfx and uGOP
......................................................................
Patch Set 20: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83705/comment/824eb1fc_19bdfae4?usp... :
PS20, Line 15: Cq-Depend: CB:83769, CB:83770
please remove this. We don't use this here (all dependent CLs should be part of the patch train for CI to pick it in order). We typically add this when we are working across the gerrit project and has inter-dependency like coreboot CL has a dependency over FSP CL>
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83705?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic8fe4ca5234de7f8e579f950f6ccbf750f4c7950
Gerrit-Change-Number: 83705
Gerrit-PatchSet: 20
Gerrit-Owner: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 07 Aug 2024 20:13:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes