[coreboot-gerrit] Change in coreboot[master]: Revert "mb/google/dedede: Program VCCIO selection for EN_SPKR GPIO"

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has submitted this change. ( https://review.coreboot.org/c/coreboot/+/56615 )

Change subject: Revert "mb/google/dedede: Program VCCIO selection for EN_SPKR GPIO"
......................................................................

Revert "mb/google/dedede: Program VCCIO selection for EN_SPKR GPIO"

This reverts commit ce79ceec86a38145b3a27aa4c78cf83a76cd51d0. This has
introduced a regression in mainboards using JSL SoC such that it
overrides the soft straps for all the GPIOs. This in turn has led to
some of the peripherals not working.

Change-Id: Ifea5d4d0f474873f8bf4818ec1986e534f455216
Signed-off-by: Karthikeyan Ramasubramanian 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/56615
Reviewed-by: Evan Green 
Reviewed-by: Furquan Shaikh 
Reviewed-by: Patrick Georgi 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/google/dedede/Makefile.inc
D src/mainboard/google/dedede/fw_config.c
2 files changed, 0 insertions(+), 18 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved
  Furquan Shaikh: Looks good to me, approved
  Evan Green: Looks good to me, approved

diff --git a/src/mainboard/google/dedede/Makefile.inc b/src/mainboard/google/dedede/Makefile.inc
index cc815d8..1b5503d 100644
--- a/src/mainboard/google/dedede/Makefile.inc
+++ b/src/mainboard/google/dedede/Makefile.inc
@@ -9,7 +9,6 @@
 ramstage-y += mainboard.c
 ramstage-y += ec.c
 ramstage-y += board_info.c
-ramstage-$(CONFIG_FW_CONFIG) += fw_config.c

VARIANT_DIR:=$(call strip_quotes,$(CONFIG_VARIANT_DIR))

diff --git a/src/mainboard/google/dedede/fw_config.c b/src/mainboard/google/dedede/fw_config.c
deleted file mode 100644
index 178f0e1..0000000
--- a/src/mainboard/google/dedede/fw_config.c
+++ /dev/null
@@ -1,17 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-#include <bootstate.h>
-#include <fw_config.h>
-#include <gpio.h>
-
-static const struct pad_config spkr_pads[] = {
-	PAD_CFG_GPO_VCCIOSEL(GPP_D17, 0, PLTRST, 1V8),
-};
-
-static void fw_config_handle(void *unused)
-{
-	if (fw_config_probe(FW_CONFIG(AUDIO_AMP, RT1015P_AUTO))) {
-		gpio_configure_pads(spkr_pads, ARRAY_SIZE(spkr_pads));
-	}
-}
-BOOT_STATE_INIT_ENTRY(BS_DEV_ENABLE, BS_ON_ENTRY, fw_config_handle, NULL);