Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38247 )
Change subject: soc/intel/common/cse: Add consistent HECI command id/group id naming ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38247/3/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/38247/3/src/soc/intel/common/block/... PS3, Line 23:
nit: In the next CL, you are updating to use tabs for other macro definitions. […]
Addressed in the patch : https://review.coreboot.org/c/coreboot/+/38384/2
https://review.coreboot.org/c/coreboot/+/38247/3/src/soc/intel/common/block/... PS3, Line 167: #define CSE_RESET_ONLY 3 These flags grouped with cse_hmrfpo_enable() in the patch - https://review.coreboot.org/c/coreboot/+/38384/2.
https://review.coreboot.org/c/coreboot/+/38247/3/src/soc/intel/common/block/... PS3, Line 170: #define MKHI_HMRFPO_DISABLED 0 : #define MKHI_HMRFPO_LOCKED 1 : #define MKHI_HMRFPO_ENABLED 2
nit: This should probably be moved up under MKHI_HMRFPO_GET_STATUS on line 34.
These flags grouped with cse_hmrfpo_enable() in the patch - https://review.coreboot.org/c/coreboot/+/38384/2.