Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42706 )
Change subject: mb/amd/mandolin: maximize CBFS size ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42706/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42706/1//COMMIT_MSG@7 PS1, Line 7: mb/amd/mandolin: maximize CBFS size
Maximize CBFS size (316 kB increase)
don't think that it matters much how much the cbfs grew. the old value was a "close enough" value and this is the calculated one after moving some things around
https://review.coreboot.org/c/coreboot/+/42706/1/src/mainboard/amd/mandolin/... File src/mainboard/amd/mandolin/Kconfig:
https://review.coreboot.org/c/coreboot/+/42706/1/src/mainboard/amd/mandolin/... PS1, Line 32: Mandolin
For being able to compare different board configurations, the board name shouldn’t be in the descrip […]
This maximum cbfs size is very specific to the mandolin fmap, so I don't see much reason to remove mandolin from the description. I could just remove the text; added that to make clear where that value comes from