Attention is currently required from: Arthur Heymans, ron minnich.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62574 )
Change subject: cbfstool/linux_trampoline: Fill the ACPI RSDP entry
......................................................................
Patch Set 5:
(1 comment)
File util/cbfstool/linux_trampoline.c:
https://review.coreboot.org/c/coreboot/+/62574/comment/5db01126_f983f907
PS4, Line 1: /* This file is automatically generated. Do not manually change */
Totally off-topic, but should we automate this a bit better (so that we no longer have to check in […]
We could, yeah. Although I think the difference there is that not everyone might have flex/bison installed and we don't want to make it unnecessarily complicated for them. This here just needs the toolchain parts we already have anyway. Also, flex/bison compiled files are ugly but they are still somewhat readable (at least you could tell if there was malware hidden in it or something), a hex array is completely opaque.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62574
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I688b94608b03b0177c42d2834c7e3beb802ae686
Gerrit-Change-Number: 62574
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Fri, 04 Mar 2022 02:21:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment