Wilson Chou has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/71694 )
Change subject: arch/x86/smbios: Modify smbios type 9 data bus width ......................................................................
arch/x86/smbios: Modify smbios type 9 data bus width
According to smbios spec DSP0134_3.6.0, data bus width indicates eletrical bus width. But now every data bus width of slot information shows 1 that represents "SlotDataBusWidthOther".
Tested=On OCP CraterLake, dmidecode -t 9 shows the expected results. For example, before this patch result: Handle 0x001E, DMI type 9, 19 bytes System Slot Information Designation: SSD0_M2_Boot_Drive Type: x4 M.2 Socket 3 Current Usage: In Use Length: Short Characteristics: 3.3 V is provided PME signal is supported Bus Address: 0000:bc:00.0 Data Bus Width: 1 Peer Devices: 0
After this patch result: Handle 0x001E, DMI type 9, 19 bytes System Slot Information Designation: SSD0_M2_Boot_Drive Type: x4 M.2 Socket 3 Current Usage: In Use Length: Short Characteristics: 3.3 V is provided PME signal is supported Bus Address: 0000:bc:00.0 Data Bus Width: 10 Peer Devices: 0
Change-Id: I1c72c422e0fdc136f4ed42c5c6818423aabc2704 Signed-off-by: Wilson Chou Wilson.Chou@quantatw.com --- M src/arch/x86/smbios.c 1 file changed, 44 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/71694/1
diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c index 8d9de7c..daa006e 100644 --- a/src/arch/x86/smbios.c +++ b/src/arch/x86/smbios.c @@ -879,7 +879,7 @@ t->segment_group_number = 0; t->bus_number = bus; t->device_function_number = dev_func; - t->data_bus_width = SlotDataBusWidthOther; + t->data_bus_width = bandwidth;
const int len = smbios_full_table_len(&t->header, t->eos); *current += len;