Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29106 )
Change subject: lib/ramtest: Use Kconfig switch CONFIG_RAMBASE for RAM test ......................................................................
Patch Set 2:
Patch Set 2:
Patch Set 2:
Patch Set 2:
That is an arbitrary address that is "tested" here. For all the platforms with RELOCATABLE_RAMSTAGE=y, CONFIG_RAMBASE is no longer where ramstage will be loaded as it's dynamically located somewhere high inside CBMEM.
In my opinion testing some address near CBMEM / IMD root (or even cbmem_top()) would be more useful, as that will be utilised before ramstage region.
Thank you for the clarification Kyösti, then I was wrong here. Should we still follow the CBMEM approach? Otherwise I can abandon this patch. Sorry for the noise.
With the few remaining quick_ram_check() calls, I think checking memory near CBMEM / IMD root would be good option.
Sounds like a good idea as the first thing placed in RAM is cbmem right after memory init.