Attention is currently required from: Jason Nien, Jon Murphy, Martin Roth, Tim Van Patten, Karthik Ramasubramanian, Mark Hasemeyer.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74609 )
Change subject: mb/google/skyrim: Add mainboard chip.h
......................................................................
Patch Set 8:
(1 comment)
File src/mainboard/google/skyrim/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/74609/comment/ddb33b4f_5d36bf59
PS8, Line 2: chip mainboard/google/skyrim/variants/baseboard
Hrmm, I agree with Arthur, this looks strange. The goal is to just include a mainboard specific `.h` in the `static.c`. We can either make the device tree parser look for a mainboard/devicetree.h, or we can include a mainboard specific header in the soc/amd/mendocino/chip.h. The former is probably the least surprising.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74609
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic609d294135e2982064cb1c1fe6eac98dc24086f
Gerrit-Change-Number: 74609
Gerrit-PatchSet: 8
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Mark Hasemeyer
markhas@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Mark Hasemeyer
markhas@google.com
Gerrit-Comment-Date: Mon, 24 Apr 2023 15:25:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment