Attention is currently required from: Raul Rangel, Jon Murphy, Paul Menzel, Tim Van Patten, Mark Hasemeyer.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74106 )
Change subject: mb/google/myst: Add ACPI configuration for USB ports ......................................................................
Patch Set 25:
(4 comments)
File src/mainboard/google/myst/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/74106/comment/8595707a_2f1aa840 PS25, Line 49: register "desc" = ""USB2 Type-A Port A0 (MLB)"" This is an internal port for UCAM.
https://review.coreboot.org/c/coreboot/+/74106/comment/df0ae959_a0c42a61 PS25, Line 54: register "desc" = ""User-Facing Camera"" This is used by WCAM
https://review.coreboot.org/c/coreboot/+/74106/comment/60db6074_716142f3 PS25, Line 59: Facing This is used by BT.
https://review.coreboot.org/c/coreboot/+/74106/comment/87604368_943f9541 PS25, Line 69: chip drivers/usb/acpi : register "desc" = ""USB3 Type-A Port A0 (DB)"" : register "type" = "UPC_TYPE_USB3_A" : register "group" = "ACPI_PLD_GROUP(2, 1)" : device ref usb3_port5 on end : end : chip drivers/usb/acpi : register "desc" = ""USB2 Type-A Port A0 (MLB)"" : register "type" = "UPC_TYPE_USB3_A" : register "group" = "ACPI_PLD_GROUP(2, 1)" : device ref usb2_port5 on end : end : chip drivers/usb/acpi : register "desc" = ""Bluetooth"" : register "type" = "UPC_TYPE_INTERNAL" : register "has_power_resource" = "true" : register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_154)" : register "enable_delay_ms" = "500" : register "enable_off_delay_ms" = "200" : register "use_gpio_for_status" = "true" : device ref usb2_port6 on end : end Nothing in this XHCI seems used based on the schematics.