Attention is currently required from: Angel Pons, Elyes Haouas, Felix Held, Julius Werner.
Arthur Heymans has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/84059?usp=email )
Change subject: drivers/spi: Stop using a variable-length array, 2nd try
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84059/comment/9118cd97_ec8bd339?usp... :
PS2, Line 22: in
nit: if you move `in` to the next line, this paragraph would have the same line length as the other two
Everything just has the max len allowed for a line.
https://review.coreboot.org/c/coreboot/+/84059/comment/898fa1bd_9abc70c1?usp... :
PS2, Line 27: https://review.coreboot.org/c/coreboot/+/50480
I'd reference the commit hash instead
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84059?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I157ecec69c049ead06467b0328efd7d1a09bd268
Gerrit-Change-Number: 84059
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Fri, 30 Aug 2024 12:20:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com